Thank god! MSN 1.3.9

eric256 · Posted: Sat Mar 20, 2004 6:28 am Post subject:

Here it is.

Keenie · Almost An Agent Joined: 31 Oct 2003 Posts: 1071

yeah? what did you do to it? change log hasnt been updated since feb.

the syn things?

also, our msmp9 support for ADD is broke, it will keep adding and adding and adding since it gets an ADD reply back saying they have been added to the AL/BL

this should fix it

eric256 · Posted: Sat Mar 20, 2004 5:26 pm Post subject:

ACtualy its the socket code. Check out do_one_loop now. Completly rewrote. I'm still working on tweaking it to work perfectly. I seem to be haveing trouble with the add if they aren't on the list already. I took that part out for now.

Mojave · Almost An Agent Joined: 01 Nov 2003 Posts: 1434

Did you take the "add if not already on list" part out of the one you posted here? Because that is the major problem I am having now too. In addition, the bot will immediately sign off in some cases - trying to figure out why.

Also, I added the code for dealing with the multi-sized @data lists in LST. That deals with some bugs.

I handle LSG now and store the GUID for the "Friends" group in a global variable $GUID for now. That is needed for the rewritten addcontact and remcontact which take the $GUID rather than just an integer.

eric256 · Posted: Sun Mar 21, 2004 2:14 am Post subject:

By global you mean a hash value inside $msn right?
Smile

I took out the add contact part in mine because it caused the bot to sign off immediatly.

eric256 · Posted: Sun Mar 21, 2004 3:54 am Post subject:

Okay here is an update. I combined mojaves changes and mine. I change the ADC handler to do nothing because it got stuck in an infinite loop if i left it in. Groups are now stored in $msn->{Groups}->{<>} = $guid. Since MSN is starting to care about such things. We should also store the GUID sent with each user on the list. For bitmask it pops the last element off the LST, if it has letters in it then it figures that must realy be the GUID and pops the next one off for the bitmask. The rest of the info is read as a hash. Mojave says that MSNP9 has two different lenght LST message, i dunno so someone else will have to look at that. Other than those I don't think there were many other changes. It seems to work good and add users when offline and online and it get status messages. It realy should be prettied up and i wanna get rid fo GetMaster so any ideas on that are welcome Smile

Mojave · Almost An Agent Joined: 01 Nov 2003 Posts: 1434

Slightly modified the addcontact and remcontact methods. addcontact does what it always did (though I left the new now useless? code in there), without a need for the GUID. remcontact uses a GUID for the Friends group. Without that passed along, it would crash. We still need to figure this all out. Actually, in the ADC sent back to the server after we call an ADC, there is a C=ID, as Eric mentioned. Maybe that is the group the user was added to?? Kind of rambling here, heh. I also turned back on the "uh oh, this user not taken care of" code.

It all seems to be working. Might still be getting that 403 error, but not sure.

HELP US, HELP YOU!