how to select data in database with valid of romote_addr

littlestar · Newbie Joined: 23 Aug 2005 Posts: 4

I'm learning Perl. and I have a question, hope you can support for me

I get ip address of my computer. It has valid.
But I can't select query from database with this valid. It has error.
There is some thing which I want to say

#-------------------------------------------------------------------

my use strict;
use lib ".";
require "CGI.pl";

use vars qw(
$vars
);

# Check whether or not the user is logged in and, if so, set the $::userid
use Test::Constants;
Test->login(LOGIN_OPTIONAL);

my $ipaddr = $ENV{'REMOTE_ADDR'};
# print $ipaddr; --> output: 192.168.5.113

SendSQL("SELECT * FROM language WHERE ippaddr = '$ipaddr'");
#this query can't select, it has error :

#Insecure dependency in parameter 1 of DBI::db=HASH(0x91bbd4c)
#->prepare method call while running with -T switch at Bugzilla/DB.pm line 60

#-----------------------------------------------------
#if I use this how, it's OK.

#$ipaddr = '192.168.5.113';
#SendSQL("SELECT * FROM language WHERE ippaddr = '$ipaddr'");
#------------------------------------------------------

# Return the appropriate HTTP response headers.
my $cgi = Test->cgi;
print $cgi->header();

# Generate and return the UI (HTML page) from the appropriate template.
my $template = Test->template;

$template->process("index.html.tmpl", $vars)
|| ThrowTemplateError($template->error());

#-------------------------------------------------------

I can't understand why, please help me

eric256 · Posted: Wed Aug 24, 2005 4:01 am Post subject:

First line should be
use strict;
not
my use strict;

Since I have no idea what SendSQL does it is hard to say what your problem is. Generaly it is a bad idea to embed a variable in a query. Instead you should use place holders. If you where using DBI then it would look like

littlestar · Newbie Joined: 23 Aug 2005 Posts: 4

Thanks eric256, but... I can't still do it with your way. It's here:

HELP US, HELP YOU!