If Else Statement Problem

Cheater · Senior Member Joined: 10 Jun 2005 Posts: 236

I'm trying to make a bot from pretty much scratch. I'm editing the on_im.pl handler to try and have my bot read from a .txt file something that looks like this:

Hi:Hi $client
How are you:I am fine, thanks for asking
Did you have a nice day:I have had a nice day so far

Then, the bot would split it at the colon into $input and $output. It would compare $msg to $input. If they match, it sets $output as $reply, and later returns $reply. I also have an Else statement in there to catch any input that is not on the .txt file. The else statement does about the same thing. Except, instead of setting $output as $reply, it sets a predetermined message as $reply. My problem is that my bot will ONLY return the else statement reply, not the input output reply. Here is on_im.pl:

Matthew Fenton_old · Newbie Joined: 01 Jul 2005 Posts: 1

Try something like this also note you do not need to quite variables..

Code:

sub on_im {
my ($aim,$client,$msg,$away) = @_;

my $screenname = $aim->screenname();
my $time = localtime();
if (!-d "./logs/$client") {
   mkdir ("./logs/$client");
}
# Make sure this wasn't an "away message"
if ($away == 0) {
   # Filter the message for HTML.
   $msg =~ s/<(.|\n)+?>//g;

   print "$time\n"
      . "[$client] $msg\n";

   # Open Client's Log File (Read, Write and Close it)

   open(FILE,">>./logs/$client/log.txt");
   print FILE "$time\n$msg\n\n";
   close(FILE);

   open (REPLYDAT, "./ifmsgisthen.txt");
   @replydat = <REPLYDAT>;
   close (REPLYDAT);
   foreach $replydatline (@replydat) {
      my($input,$output) = split(/:/, $replydatline, 2);
      if ($msg eq $input) {
         $reply = $output;
      } else {
         $reply = "Nice.. Nice..";
      }
   }

   # Type sleep (Avoid Rate limit) and send msg
   $aim->send_typing_status ($client,TYPINGSTATUS_STARTED);
   sleep (2);
   $aim->send_im ($client,$reply);

   # End typing status.
   $aim->send_typing_status ($client,TYPINGSTATUS_FINISHED);
} else {
   return;
}
}

1;

Cheater · Senior Member Joined: 10 Jun 2005 Posts: 236

what do you mean by quit variables? And your change didn't work.

Cer · Posted: Fri Jul 01, 2005 11:26 pm Post subject:

Matt meant to say QUOTE variables.

i.e.
$new = "$old"; <not necessary
$new = $old;

Only use quotes when you need to put other things in the string besides just a variable.
___________________

Also, your problem is here:

Cheater · Senior Member Joined: 10 Jun 2005 Posts: 236

That didn't work, so I tried adding some print statements in. Here is on_im.pl:

eric256 · Posted: Mon Jul 04, 2005 11:12 pm Post subject:

Instead of printing "$replydatline" you should try printing out what you split apart. Also print what you are comparing before the if line. Something like print "'$msg' eq '$input;" might be very informative.

HELP US, HELP YOU!